fixup! fixup! Duplicate check on import should be run in background T…

…ask JabRef#4963 (created background task for duplicate chec)
dimmonn · May 18, 2019 · b4cece8 · b4cece8
1 parent d249da1
commit b4cece8
Showing 1 changed file with 9 additions and 7 deletions.
diff --git a/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java b/src/main/java/org/jabref/gui/importer/ImportEntriesDialog.java
@@ -108,13 +108,15 @@ private void initialize() {
                     container.getStyleClass().add("entry-container");
                     BindingsHelper.includePseudoClassWhen(container, entrySelected, addToggle.selectedProperty());
 
-                    if (viewModel.hasDuplicate(entry)) {
-                        Button duplicateButton = IconTheme.JabRefIcons.DUPLICATE.asButton();
-                        duplicateButton.setTooltip(new Tooltip(Localization.lang("Possible duplicate of existing entry. Click to resolve.")));
-                        duplicateButton.setOnAction(event -> viewModel.resolveDuplicate(entry));
-                        container.getChildren().add(1, duplicateButton);
-                    }
-
+                    Callable<Boolean> hasDuplicateEntryTask = () -> viewModel.hasDuplicate(entry);
+                    BackgroundTask.wrap(hasDuplicateEntryTask).onSuccess(e -> {
+                        if (e) {
+                            Button duplicateButton = IconTheme.JabRefIcons.DUPLICATE.asButton();
+                            duplicateButton.setTooltip(new Tooltip(Localization.lang("Possible duplicate of existing entry. Click to resolve.")));
+                            duplicateButton.setOnAction(event -> viewModel.resolveDuplicate(entry));
+                            container.getChildren().add(1, duplicateButton);
+                        }
+                    }).executeWith(Globals.TASK_EXECUTOR);
                     return container;
                 })
                 .withOnMouseClickedEvent((entry, event) -> entriesListView.getCheckModel().toggleCheckState(entry))