feat: Add support for Automated Message nonce handling #10381

JMTK · 2024-07-09T19:34:03Z

Please describe the changes this PR makes and why it should be merged:
Took a stab at doing this, let me know if there's any issues! Fixes #10323

Only thing I thought about was to instead make this a function you can pass in to generate nonces, so something like

if (typeof this.client.options.generateNonce === 'function') {
    options.nonce = this.client.options.generateNonce();
}

But the users may run into issues, such as the 25 character limit, generating high collision nonces, etc

Status and versioning classification:
Minor

vercel · 2024-07-09T19:34:08Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

2 Skipped Deployments

Name	Status	Preview	Comments	Updated (UTC)
discord-js	⬜️ Ignored (Inspect)	Visit Preview		Aug 19, 2024 2:02pm
discord-js-guide	⬜️ Ignored (Inspect)	Visit Preview		Aug 19, 2024 2:02pm

packages/discord.js/src/structures/interfaces/TextBasedChannel.js

packages/discord.js/typings/index.d.ts

Jiralite

Should we handle when enforceNonce: false is explicitly passed?

const createdMessage = await message.channel.send({
	content: "hello",
	enforceNonce: false,
});

// `createdMessage` has a nonce which is enforced despite `enforceNonce` being `false`.

packages/discord.js/src/structures/interfaces/TextBasedChannel.js

…to not generate a nonce, and PR feedback

packages/discord.js/src/structures/interfaces/TextBasedChannel.js

packages/discord.js/src/structures/MessagePayload.js

Co-authored-by: Almeida <github@almeidx.dev>

packages/discord.js/src/structures/MessagePayload.js

cobaltt7 · 2024-07-26T18:25:33Z

@JMTK you force pushed, which (i assume unintentionally) closed the PR
you may find it useful to learn how to use branches

JMTK · 2024-07-26T18:27:38Z

oh woops, i thought i had it on a branch. i was working on creating a new PR and accidentally did that

Fixed!

Resolved

See: * https://discord.com/developers/docs/change-log#enforced-nonces-on-create-message-endpoint * discordjs/discord.js#10301 A (hopefully) upcoming discord.js change will simplify this: discordjs/discord.js#10381

* Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <github@almeidx.dev> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me>

* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <github@almeidx.dev> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> * feat(Attachment): add `title` (#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <jake.morrison24@gmail.com> Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> Co-authored-by: Danial Raza <danialrazafb@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: Jeroen Claassens <support@favware.tech> Co-authored-by: DD <didinele.dev@gmail.com>

* Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <github@almeidx.dev> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me>

* build: bump discord-api-types to 0.37.95 * feat: Add support for Automated Message nonce handling (discordjs#10381) * Add support for Automated Message nonce handling * Fix options property * Address PR feedback * Handled case where it was explicitly set to false for that iteration to not generate a nonce, and PR feedback * Fix lint issue * Fix lint issue * Move to MessagePayload.resolveBody instead * Fix test errors * Update packages/discord.js/src/structures/MessagePayload.js Co-authored-by: Almeida <github@almeidx.dev> * PR feedback * Merge * Let and not const --------- Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> * feat(Attachment): add `title` (discordjs#10423) Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * types: Fix wrong auto moderation target type (discordjs#10391) types: fix wrong auto moderation target type Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * feat(builders): update to @sapphire/shapeshift v4 (discordjs#10291) feat: update to @sapphire/shapeshift v4 * refactor(actions): safer getChannel calls (discordjs#10434) * refactor(actions): safer getChannel calls * chore: consistency --------- Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> * build: bump discord-api-types tp 0.37.96 --------- Co-authored-by: Jacob Morrison <jake.morrison24@gmail.com> Co-authored-by: Almeida <github@almeidx.dev> Co-authored-by: Almeida <almeidx@pm.me> Co-authored-by: Danial Raza <danialrazafb@gmail.com> Co-authored-by: kodiakhq[bot] <49736102+kodiakhq[bot]@users.noreply.github.com> Co-authored-by: Jiralite <33201955+Jiralite@users.noreply.github.com> Co-authored-by: Jeroen Claassens <support@favware.tech> Co-authored-by: DD <didinele.dev@gmail.com>

JMTK added 2 commits July 9, 2024 15:30

Add support for Automated Message nonce handling

35005cf

Fix options property

c9fecf2

JMTK requested a review from a team as a code owner July 9, 2024 19:34

JMTK requested review from vladfrangu, iCrawl, kyranet and SpaceEEC July 9, 2024 19:34

github-actions bot added the packages:discord.js label Jul 9, 2024

Jiralite added this to the discord.js 14.16 milestone Jul 9, 2024

Jiralite requested changes Jul 9, 2024

View reviewed changes

packages/discord.js/src/structures/interfaces/TextBasedChannel.js Outdated Show resolved Hide resolved

packages/discord.js/typings/index.d.ts Outdated Show resolved Hide resolved

JMTK changed the title ~~Add support for Automated Message nonce handling~~ [feat] Add support for Automated Message nonce handling Jul 9, 2024

Jiralite added the semver:minor label Jul 9, 2024

Address PR feedback

921ffb7

JMTK changed the title ~~[feat] Add support for Automated Message nonce handling~~ feat: Add support for Automated Message nonce handling Jul 9, 2024

Jiralite previously requested changes Jul 10, 2024

View reviewed changes

packages/discord.js/src/structures/interfaces/TextBasedChannel.js Outdated Show resolved Hide resolved

JMTK added 5 commits July 10, 2024 14:34

Handled case where it was explicitly set to false for that iteration …

b582b29

…to not generate a nonce, and PR feedback

Merge branch 'main' into main

5277678

Fix lint issue

5799001

Fix lint issue

3fe742e

Merge branch 'main' into main

295bae6

JMTK requested a review from Jiralite July 11, 2024 18:43

almeidx previously requested changes Jul 13, 2024

View reviewed changes

packages/discord.js/src/structures/interfaces/TextBasedChannel.js Outdated Show resolved Hide resolved

JMTK added 3 commits July 15, 2024 11:27

Move to MessagePayload.resolveBody instead

99fa95a

Fix test errors

ceb0b7a

Merge branch 'main' into main

171c1cc

almeidx reviewed Jul 15, 2024

View reviewed changes

packages/discord.js/src/structures/MessagePayload.js Show resolved Hide resolved

packages/discord.js/src/structures/MessagePayload.js Outdated Show resolved Hide resolved

Update packages/discord.js/src/structures/MessagePayload.js

22523a5

Co-authored-by: Almeida <github@almeidx.dev>

vladfrangu previously requested changes Jul 16, 2024

View reviewed changes

packages/discord.js/src/structures/MessagePayload.js Outdated Show resolved Hide resolved

packages/discord.js/src/structures/MessagePayload.js Show resolved Hide resolved

PR feedback

4edb8b6

JMTK added 2 commits July 16, 2024 17:19

Merge

4011719

Fix merge

fd4d797

JMTK requested review from vladfrangu and almeidx July 16, 2024 21:20

JMTK added 2 commits July 16, 2024 17:34

Let and not const

935af4f

Merge branch 'main' into main

50096fc

JMTK closed this Jul 26, 2024

JMTK force-pushed the main branch from 50096fc to bf6761a Compare July 26, 2024 17:44

JMTK reopened this Jul 26, 2024

JMTK force-pushed the main branch from 29ed309 to 50096fc Compare July 26, 2024 18:41

Merge branch 'main' into main

399fa0e

kyranet approved these changes Jul 27, 2024

View reviewed changes

Merge branch 'main' into main

d973ea6

didinele approved these changes Aug 6, 2024

View reviewed changes

astiob mentioned this pull request Aug 12, 2024

Set enforceNonce on all send() calls to prevent message duplication 9vult/nino#7

Merged

vladfrangu approved these changes Aug 19, 2024

View reviewed changes

Merge branch 'main' into main

5dfe1a6

kodiakhq bot merged commit 2ca187b into discordjs:main Aug 19, 2024
6 checks passed

almeidx mentioned this pull request Aug 20, 2024

fix(MessagePayload): crash when resolving body #10454

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: Add support for Automated Message nonce handling #10381

feat: Add support for Automated Message nonce handling #10381

JMTK commented Jul 9, 2024

vercel bot commented Jul 9, 2024 •

edited

Loading

Jiralite left a comment •

edited

Loading

cobaltt7 commented Jul 26, 2024

JMTK commented Jul 26, 2024 •

edited

Loading

feat: Add support for Automated Message nonce handling #10381

feat: Add support for Automated Message nonce handling #10381

Conversation

JMTK commented Jul 9, 2024

vercel bot commented Jul 9, 2024 • edited Loading

Jiralite left a comment • edited Loading

Choose a reason for hiding this comment

cobaltt7 commented Jul 26, 2024

JMTK commented Jul 26, 2024 • edited Loading

vercel bot commented Jul 9, 2024 •

edited

Loading

Jiralite left a comment •

edited

Loading

JMTK commented Jul 26, 2024 •

edited

Loading