Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for current logic #6

Merged
merged 1 commit into from
Jun 30, 2022
Merged

Add tests for current logic #6

merged 1 commit into from
Jun 30, 2022

Conversation

janzenisaac
Copy link
Contributor

@janzenisaac janzenisaac commented Jun 28, 2022

I have cleaned up the redirect logic a lot, but there are some known ember bugs that make the process of passing params a little painful...
emberjs/ember.js#12169
emberjs/ember.js#18577

eg. when selecting tracked, and then trying to navigate to top. It does not want to pass the param of f=tracked along.

@janzenisaac janzenisaac merged commit 0cd46d1 into main Jun 30, 2022
@janzenisaac janzenisaac deleted the add-tests branch June 30, 2022 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants