UNRI2-140: Add model viewer and remove lights + ortho cam #9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JojoVes
reviewed
Jul 14, 2023
JojoVes
reviewed
Jul 14, 2023
…into test140 removed the js/dist files that had conflicts because it's cleaner to just recompile them
Resolving merge conflicts
Camera settings get passed through drupal settings as strings, even though they are for number fields; the PerspectiveCamera constructor apparently doesn't handle string values well, no errors, just darkness, which is remedied by ensuring we pass numbers. Annoying bug with a simple fix.
Cast setting values to numbers
cleanup test js
JojoVes
approved these changes
Aug 10, 2023
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.