Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't check for anonymous user access at index time. #12

Closed
wants to merge 1 commit into from

Conversation

alxp
Copy link
Collaborator

@alxp alxp commented Nov 9, 2023

Just removing the condition where the indexer bails if a media is not accessible to Anonymous. We have implemented passing auth headers to Mirador, see this Draft PR: Islandora/islandora_mirador#32

@adam-vessey
Copy link
Contributor

The visibility of content in the Solr index is related more to who that index will/can be used by, and not so much what other services might make use of its results. As in: Because the index is usable by anon, there should not be anything in it that cannot be accessed by anon to avoid potentially leaking data via the index.

That said, things could potentially be made toggleable via configuration if admins are comfortable with doing so, as in, something like: https://github.com/discoverygarden/islandora_hocr/compare/feature/skippable-access-check ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants