Revert "Removed |safe filter from help text (#66)"

This reverts commit 52156bf.
django-crispy-forms · Jan 13, 2022 · e1c12cd · e1c12cd
1 parent 8bccd51
commit e1c12cd
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 24 deletions.
diff --git a/crispy_bootstrap5/templates/bootstrap5/layout/help_text.html b/crispy_bootstrap5/templates/bootstrap5/layout/help_text.html
@@ -1,7 +1,7 @@
 {% if field.help_text %}
     {% if help_text_inline %}
-        <span id="hint_{{ field.auto_id }}" class="text-muted">{{ field.help_text }}</span>
+        <span id="hint_{{ field.auto_id }}" class="text-muted">{{ field.help_text|safe }}</span>
     {% else %}
-        <small id="hint_{{ field.auto_id }}" class="form-text text-muted">{{ field.help_text }}</small>
+        <small id="hint_{{ field.auto_id }}" class="form-text text-muted">{{ field.help_text|safe }}</small>
     {% endif %}
 {% endif %}
diff --git a/tests/forms.py b/tests/forms.py
@@ -284,12 +284,3 @@ class GroupedChoiceForm(forms.Form):
         widget=forms.CheckboxSelectMultiple, choices=choices
     )
     radio = forms.MultipleChoiceField(widget=forms.RadioSelect, choices=choices)
-
-
-class HelpTextForm(forms.Form):
-    email = forms.EmailField(
-        label="email",
-        required=True,
-        widget=forms.TextInput(),
-        help_text="Insert your email<>&",
-    )
diff --git a/tests/results/help_text_escape.html b/tests/results/help_text_escape.html
diff --git a/tests/test_layout.py b/tests/test_layout.py
@@ -25,7 +25,6 @@
     CrispyTestModel,
     FileForm,
     FileFormRequired,
-    HelpTextForm,
     InputsForm,
     LabelForm,
     SampleForm,
@@ -641,10 +640,3 @@ def test_flat_attrs_safe():
     )
     form.helper.form_tag = False
     assert parse_form(form) == parse_expected("flat_attrs.html")
-
-
-def test_help_text_escape():
-    form = HelpTextForm()
-    form.helper = FormHelper()
-    form.helper.form_tag = False
-    assert parse_form(form) == parse_expected("help_text_escape.html")