Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Help text not rendering as "safe" #92

Closed
Archmonger opened this issue Jan 9, 2022 · 2 comments
Closed

Help text not rendering as "safe" #92

Archmonger opened this issue Jan 9, 2022 · 2 comments

Comments

@Archmonger
Copy link
Contributor

The bootstrap4 template within crispy forms allows embedded HTML within help text. This simplifies bolding texts and whatnot. crispy-bootstrap5 does not appear to follow the same convention.

Issue example
image

Archmonger added a commit to Archmonger/crispy-bootstrap5 that referenced this issue Jan 9, 2022
@Archmonger
Copy link
Contributor Author

I'm seeing this commit in the logs 52156bf that appears to mean that the removal of safe was intentional.

I personally don't see much of a problem with help_text being safe, as help_text is typed by the developer. If they want to inject HTML inline via a string, I'd say just let them.

I don't think the scenario exists where help text can unintentionally bork a page.

@smithdc1
Copy link
Member

Yes, we should restore the safe filter on help text to be consistent with Django itself. See.

django/django@4c60c3e

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants