Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Django/Python versions in Automated Tests #100

Merged
merged 2 commits into from
Mar 15, 2022
Merged

Update Django/Python versions in Automated Tests #100

merged 2 commits into from
Mar 15, 2022

Conversation

jmoppel
Copy link
Contributor

@jmoppel jmoppel commented Mar 9, 2022

Updated the automated tests run by Github Actions to only use supported
versions and combinations of Python and Django.

  • Added Python 3.10 to Github automated tests for Django 3.2 and 4.0.
  • Removed Python 3.6 and Django 2.2/3.1 from tests {deprecated upstream).
  • Run linters using the latest version of Python (3.10).
  • Fix test suite so it passes (incorrect results file)

@jmoppel
Copy link
Contributor Author

jmoppel commented Mar 9, 2022

Apologies for accidentally closing #99! That was my first time using Github Pull Requests. I will submit another PR to replace #99 once this request has been merged.

@smithdc1
Copy link
Member

smithdc1 commented Mar 9, 2022

Thanks for this. This looks good to me.

I think just one amend needed before I merge this. Could you also update the setup.py file. In particular the python_requires setting, but would be useful to update the classifiers as well.

python_requires=">=3.6",

As a bonus, I'd also take dropping Django 2.2 at this stage if you wanted update for that as well?

Updated the automated tests run by Github Actions to only use supported
versions and combinations of Python and Django.
- Added Python 3.10 to Github automated tests for Django 3.2 and 4.0.
- Removed Python 3.6 and Django 2.2/3.1 from tests {deprecated upstream).
- Run linters using the latest version of Python (3.10).
@jmoppel
Copy link
Contributor Author

jmoppel commented Mar 10, 2022

I made all the changes you suggested, including removing Django 2.2 and updating the classifiers. Would you also like for me to update publish.yml too, since it has references to Python 3.6? I'm not 100% certain what all that workflow does, so I felt it would be better to check with you first. I'm happy to add publish.yml to this PR or to create a new one -- whichever you'd prefer. Thanks!

@smithdc1
Copy link
Member

. Would you also like for me to update publish.yml too, since it has references to Python 3.6?

Yes please, let's do that here as well.

Thank you!!

@jmoppel
Copy link
Contributor Author

jmoppel commented Mar 10, 2022

Ok, everything we discussed is complete. Please let me know if anything is else needed before merging. Thanks!

@smithdc1
Copy link
Member

Hi @jmoppel -- could you pull your other changes into here so we can get the test suite to pass?

https://github.com/django-crispy-forms/crispy-bootstrap5/runs/5504213317?check_suite_focus=true#step:6:61

- Python 3.7 is now the minimum required version to installl
   crispy-bootstrap5.
- Removed Django 2.2, 3.1, and Python 3.6 (deprecated upstream) from
   classifiers.
- Removed Python 3.6 from publishing test matrix
- Run the deployment process using the latest version of Python (3.10).
- Fixed a broken test results file where it incorrectly expected a
  repeated form-select (test_prepended_appended_select.html)
@jmoppel
Copy link
Contributor Author

jmoppel commented Mar 14, 2022

Done. All tests and linting actions now finish without errors on my fork.
https://github.com/jmoppel/crispy-bootstrap5/actions/runs/1982978715

@smithdc1 smithdc1 merged commit 32c3fbb into django-crispy-forms:main Mar 15, 2022
@smithdc1
Copy link
Member

@jmoppel thanks for all of your efforts. 🏅

@smithdc1 smithdc1 added this to the Next Release milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants