Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix label text for required Floating Fields #101

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix label text for required Floating Fields #101

merged 1 commit into from
Mar 16, 2022

Conversation

jmoppel
Copy link
Contributor

@jmoppel jmoppel commented Mar 16, 2022

  • For Floating Fields, added an asterisk (*) to the end of label text
    to denote a required field.
  • Enclosed the * in a span tag with the required styling (see link
    below for more info about styling the required fields asterisk)
  • Updated test result files to reflect these changes.

Asterisk CSS stying info:
https://django-crispy-forms.readthedocs.io/en/latest/crispy_tag_forms.html?highlight=asteriskField#change-required-field

- For Floating Fields, added an asterisk (*) to the end of label text
  to denote a required field.
- Enclosed the * in a span tag with the required styling (see link
  below for more info about styling the required fields asterisk)
- Updated test result files to reflect these changes.

Asterisk CSS stying info:
https://django-crispy-forms.readthedocs.io/en/latest/crispy_tag_forms.html?highlight=asteriskField#change-required-field
@smithdc1
Copy link
Member

Lgtm!

@smithdc1 smithdc1 merged commit 193ba81 into django-crispy-forms:main Mar 16, 2022
@jmoppel jmoppel deleted the fix-reqd-floating-field-label branch March 16, 2022 14:51
@smithdc1 smithdc1 added this to the Next Release milestone Sep 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants