Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Modify row template to class "row" #36

Merged
merged 2 commits into from
Mar 3, 2021
Merged

Modify row template to class "row" #36

merged 2 commits into from
Mar 3, 2021

Conversation

JimiRecard
Copy link
Contributor

@JimiRecard JimiRecard commented Mar 2, 2021 •
edited
Loading

Class "form-row" doesn't seem to do anything in bootstrap5. Class "row" seems to apply the proposed style for Row in crispy-forms.

@smithdc1 smithdc1 added this to the Version 0.3.11 milestone Mar 3, 2021
JimiRecard and others added 2 commits March 3, 2021 21:32
@JimiRecard @smithdc1
Fixed classes for Row layout object
5b4d895 
Class "form-row" is replaced by "row" in bootstrap 5.
@smithdc1
Version 0.3.1
de5e545
@smithdc1
Copy link
Member

smithdc1 commented Mar 3, 2021

Thanks @JimiRecard !

@smithdc1 smithdc1 merged commit f5510ca into django-crispy-forms:master Mar 3, 2021
@JimiRecard JimiRecard deleted the patch-1 branch March 4, 2021 00:32
@smithdc1 smithdc1 mentioned this pull request Apr 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
Version 0.3.1
Development

Successfully merging this pull request may close these issues.
2 participants
@JimiRecard @smithdc1