Fixed offset class of checkbox in form horizontal

[lauri-openscop]

A tricky way to apply the right offset class on checkbox field whitout touching the core application..

[smithdc1]

Thanks! Glad you found a way of including it in this template pack. 🏅

Could I ask you to add tests for this? See the link below for how we are writing new tests.

#44

[lauri-openscop]

I have updated test_label_class_and_field_class_bs5_offset_when_horizontal to match with the current offset method. Is that good for you ?

[smithdc1]

Thanks for this. I think this is close but it doesn't work where the number of columns is two digits. i.e. col-lg-12 would become offset-lg-1.

I was wondering if we could refactor bootstrap_checkbox_offsets in core to be a list/dict(?) of size and number of columns. We could then build the string in the template rather than code as the particular format here seems to change with each major bootstrap release.

What do you think?

[lauri-openscop]

My bad, it was cause by the slice. I didn't think about two digit columns. It should work now..
I think that if we have to change the core application the best would be to change helper.py like i said in #49 (comment) or something like that. What do you think ?

[smithdc1]

I think that github asking folk to approve each test run is a bit tiresome (I mean, once would be ok for this PR, but I've pressed it countless times for this PR alone as we've been itterating through the problem!).

As for this patch itself I think it's fine. Let's have this. 👍