accordion-flush and unique id #61
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds the possibility for accordion-flush (see https://getbootstrap.com/docs/5.0/components/accordion/#flush) and fixes the unique id for accordions. The unique id is important for the behavior of the panels. If the id is not unique, we cannot set a proper data-bs-parent and get a JS error
|
Same comments for this PR. I thought I had the accordions working? 🤔 I'll take a closer look when the tests are updated as that'll make it much easier to check 🙂. |
|
It's defintly working at first glance, but the JS error is there, and the panel needs a double click to work. I could use some help with the test. The issue is that the unique id generated contains a random number. Got any idea how I should address that on the expected HTML? EDIT Nevermind, I think I got it. If we add random.seed(0) we can fix the output. I'll try to fix the tests EDIT 2 Also, I think the tests won't work if I try the PRs one at a time. I'll try to make a single PR and close the two I've opened. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds the possibility for accordion-flush (see https://getbootstrap.com/docs/5.0/components/accordion/#flush) and fixes the unique id for accordions.
The unique id is important for the behavior of the panels. If the id is not unique, we cannot set a proper data-bs-parent and get a JS error