Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added select widget for bs4 form #21

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

smithdc1
Copy link
Member

@cpina re your note that the select widget isn't quite right.

@cpina
Copy link
Member

cpina commented Dec 11, 2020

Ha! Two days ago I did the same (with Bootstrap3 as well): cpina@544da33

I added this select:
select1

And then somehow I realised that we had a select (even with the arrow):
select2

But perhaps we should just add the simple select for clarity.

@smithdc1
Copy link
Member Author

Let's merge your version?

I think explicit is better here, it's probably due to it not being on its own we've 'missed' it before?

@cpina
Copy link
Member

cpina commented Dec 12, 2020

Last night with one my fixes it initially worked with the select but not the append-select widget. Later I'll merge yours or mine. Probably mine, I think that it had one more example for BS3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants