Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[build] nightly build is down due to gcc 8.5.0 does not fully support c++17 #7278

Closed
Rhett-Ying opened this issue Apr 8, 2024 · 6 comments · Fixed by #7279
Closed

[build] nightly build is down due to gcc 8.5.0 does not fully support c++17 #7278

Rhett-Ying opened this issue Apr 8, 2024 · 6 comments · Fixed by #7279
Labels
Work Item Work items tracked in project tracker

Comments

@Rhett-Ying
Copy link
Collaborator

🔨Work Item

IMPORTANT:

  • This template is only for dev team to track project progress. For feature request or bug report, please use the corresponding issue templates.
  • DO NOT create a new work item if the purpose is to fix an existing issue or feature request. We will directly use the issue in the project tracker.

Project tracker: https://github.com/orgs/dmlc/projects/2

Description

For now, we're using nvidia/cuda:12.1.0-cudnn8-devel-ubi8 docker base image for building. And the default gcc version is 8.5.0. When building with it, below error is thrown:

/opt/dgl/graphbolt/src/cuda/extension/unique_and_compact_map.cu(151): error: namespace "std" has no member "exclusive_scan" 

This API is introduced by #7239

Depending work items or issues

@Rhett-Ying Rhett-Ying added the Work Item Work items tracked in project tracker label Apr 8, 2024
@Rhett-Ying
Copy link
Collaborator Author

@mfbalin FYI

@Rhett-Ying
Copy link
Collaborator Author

@mfbalin could we replace it with std::partial_sum? how much is the performance downgrade?

@Rhett-Ying
Copy link
Collaborator Author

Rhett-Ying commented Apr 8, 2024

@mfbalin
Copy link
Collaborator

mfbalin commented Apr 8, 2024

Let's replace it with partial_sum, opening a quick PR.

@mfbalin
Copy link
Collaborator

mfbalin commented Apr 8, 2024

I was eagerly waiting for today's regression results. When do you think the next report is going to go out?

@Rhett-Ying
Copy link
Collaborator Author

regression build is not affected by this issue. But regression build is down last night due to other issue. I've fixed it and report is supposed to be ready tmr, around 1 o'clock AM, UTC.

vmiheer added a commit to vmiheer/dgl that referenced this issue Jun 5, 2024
Related:
dmlc#7278

Feel free to modify this PR with more info.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Work Item Work items tracked in project tracker
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants