Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

OMP pragma was added to support hetero_graph loop. #2148

Merged

Conversation

mozga-intel
Copy link
Contributor

@mozga-intel mozga-intel commented Sep 3, 2020

The OMP flag was added to support/obtain the inputs and outputs format of the matrices. This pull-request gives us the ability to get better performance in comparison with the master branch (approx. +5,6%). For brevity, the input and output format are triggered in a parallel way.

@mozga-intel mozga-intel force-pushed the mozga-intel/parallel_hetero_graph_param_in_out branch 2 times, most recently from 2794db4 to e3ac6b1 Compare September 3, 2020 18:28
@yzh119
Copy link
Member

yzh119 commented Sep 3, 2020

Could we only enable this optimization when the graph is stored on CPU? I don't think the optimization works for GPU as well.

@mozga-intel mozga-intel force-pushed the mozga-intel/parallel_hetero_graph_param_in_out branch from 1105d3b to d624a99 Compare September 8, 2020 08:05
@mozga-intel
Copy link
Contributor Author

@yzh119 Of course, done!

@mozga-intel mozga-intel force-pushed the mozga-intel/parallel_hetero_graph_param_in_out branch from d624a99 to 5a070b5 Compare September 11, 2020 10:50
Copy link
Member

@yzh119 yzh119 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with this PR.

@mozga-intel
Copy link
Contributor Author

@yzh119 Thanks for your approval, could you please tell me whether it could be merged into the master branch?

@yzh119 yzh119 merged commit 7d19b33 into dmlc:master Oct 9, 2020
BarclayII pushed a commit to BarclayII/dgl that referenced this pull request Nov 27, 2020
* OMP pragma was added to support hetero_graph loop, as follows:
pragma omp parallel for

* OMP pragma will be enabled iff the gpu is used for

Co-authored-by: Zihao Ye <expye@outlook.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants