[Performance] Use segment operators for graph readout. #2361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yzh119
changed the title
6 tasks
yzh119
added a commit
that referenced
this pull request
Nov 22, 2020
| } else { | ||
| cuda::AtomicAdd(out_buf, val); | ||
| } | ||
| } |
There was a problem hiding this comment.
We should refactor this part.
| */ | ||
| template <typename IdType, typename DType, | ||
| typename ReduceOp> | ||
| __global__ void SegmentReduceKernel( |
There was a problem hiding this comment.
SegmentReduceKernel -> SegmentReduceCmpKernel
Also, poor docstring
|
Also missing C++ tests |
BarclayII
pushed a commit
to BarclayII/dgl
that referenced
this pull request
Nov 27, 2020
* upd * upd * update * upd * upd * upd * fix * lint * lint * pylint * doc
BarclayII
pushed a commit
to BarclayII/dgl
that referenced
this pull request
Nov 27, 2020
|
Will fix the documentation issue soon, for other concerns:
|
6 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously we created a pseudo graph and applied SpMM to get graph readout results, and introduced graph creation overhead. Thus PR implements segment operators to lower this (and corresponding coo/csr conversion) overhead.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change