-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataset] Change the Data Type of the Node Features in GINDataset/TUDataset from Float64 to Float32 #2592
Conversation
Should we apply this as a standard practice to other graph classification datasets (e.g. TU)? Currently in the example, we have lines converting the dtype: https://github.com/dmlc/dgl/blob/master/examples/pytorch/gin/main.py#L25-L26 |
Good point. Updated. |
Sorry I just found these two files have the same lines, could you please clean them up together? https://github.com/dmlc/dgl/blob/master/examples/pytorch/gxn/main.py Otherwise LGTM, thanks! |
Done. |
Description
As reported in this thread by @hengruizhang98 , the node feature
attr
of the graphs inGINDataset
has a data type of float64 rather than float32. This PR addresses the issue in instantiating the datasets.@BarclayII @jermainewang This is not a critical issue and we may merge it after we are done with 0.6 release.
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change