Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gnnexplainer #2717

Merged
merged 13 commits into from
Mar 22, 2021
Merged

Gnnexplainer #2717

merged 13 commits into from
Mar 22, 2021

Conversation

KounianhuaDu
Copy link
Contributor

Description

This is the implementation of gnn-explainer. Five tasks on five synthetic datasets are conducted with a dummy gnn model. The visualization results are provided for reference.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@KounianhuaDu
Copy link
Contributor Author

@zhjwy9343

@KounianhuaDu
Copy link
Contributor Author

The pics are stored in my own repo. And the readme links to that repo. Is it appropriate?

@zhjwy9343 zhjwy9343 self-requested a review March 5, 2021 07:04
examples/pytorch/gnn_explainer/NodeExplainerModule.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/NodeExplainerModule.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/NodeExplainerModule.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/NodeExplainerModule.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/NodeExplainerModule.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/train_main.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/train_main.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/utils_graph.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/utils_graph.py Outdated Show resolved Hide resolved
examples/pytorch/gnn_explainer/utils_graph.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@zhjwy9343 zhjwy9343 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

4. Sum loss of node feature mask weights;
5. Loss of node feature mask entropy, which tries to put the mask value to either 0 or 1;

In this implementation, will use the PyG's version, but set the aggregation function of weights
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove the ", but ..." and change to a period. I didn't set the aggregation function to be optional.

@zhjwy9343
Copy link
Collaborator

LGTM

@zhjwy9343 zhjwy9343 merged commit 9aac93f into dmlc:master Mar 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants