Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Example] JKNet #2795

Merged
merged 11 commits into from
Apr 7, 2021
Merged

[Example] JKNet #2795

merged 11 commits into from
Apr 7, 2021

Conversation

xnuohz
Copy link
Contributor

@xnuohz xnuohz commented Mar 29, 2021

Description

Pytorch Implementation of JKNet in paper Representation Learning on Graphs with Jumping Knowledge Networks @mufeili

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mufeili mufeili self-requested a review April 2, 2021 07:04
@mufeili
Copy link
Member

mufeili commented Apr 5, 2021

Have you tried tuning the hyperparameters? Did you use the ones from the paper?

@xnuohz
Copy link
Contributor Author

xnuohz commented Apr 5, 2021

Have you tried tuning the hyperparameters? Did you use the ones from the paper?

I just follow the model architectures from the original paper.

@mufeili
Copy link
Member

mufeili commented Apr 5, 2021

Have you tried tuning the hyperparameters? Did you use the ones from the paper?

I just follow the model architectures from the original paper.

How about the hyperparameters like learning rate?

@xnuohz
Copy link
Contributor Author

xnuohz commented Apr 5, 2021

Have you tried tuning the hyperparameters? Did you use the ones from the paper?

I just follow the model architectures from the original paper.

How about the hyperparameters like learning rate?

I tried lr, dropout, lamb and hid-dim, it's useless.

@mufeili
Copy link
Member

mufeili commented Apr 6, 2021

Have you tried tuning the number of GNN layers? The paper said that they tried 1-6. Also 500 epochs might be too much for these two datasets. Early stopping based on validation accuracy does not work well with these two datasets.

There's also a comment left to address.

@xnuohz
Copy link
Contributor Author

xnuohz commented Apr 6, 2021

Have you tried tuning the number of GNN layers? The paper said that they tried 1-6. Also 500 epochs might be too much for these two datasets. Early stopping based on validation accuracy does not work well with these two datasets.

There's also a comment left to address.

Yes, I've already tried. I set epochs smaller with different GNN layer and mode, it still doesn't work well.

@mufeili mufeili merged commit 2afa359 into dmlc:master Apr 7, 2021
@xnuohz xnuohz deleted the jknet branch April 10, 2021 05:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants