Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[example] multi gpus training for mag240m #2835

Merged
merged 6 commits into from
Apr 13, 2021
Merged

[example] multi gpus training for mag240m #2835

merged 6 commits into from
Apr 13, 2021

Conversation

maqy1995
Copy link
Contributor

Description

the code is similar to https://github.com/dmlc/dgl/blob/master/examples/pytorch/graphsage/train_sampling_multi_gpu.py

related discussion:https://discuss.dgl.ai/t/will-mag240ms-baseline-code-use-multi-gpus-training-bring-efficiency-improvements/1878

Points that may need attention:

  1. It may be necessary to perform performance testing again on the DGL server. The first Epoch may be slower because the feature needs to be cached.
  2. I did not adjust the parameters (such as learning rate), which may cause the final accuracy rate to change.
  3. Maybe the README should be updated.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

Copy link
Collaborator

@BarclayII BarclayII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks a lot!

@BarclayII BarclayII merged commit 195f993 into dmlc:master Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants