[NN] Fix GATConv for Broadcasting with Residual Connections #2867
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
yzh119
reviewed
Apr 25, 2021
| @@ -304,7 +304,8 @@ def forward(self, graph, feat, get_attention=False): | |||
| rst = graph.dstdata['ft'] | |||
| # residual | |||
| if self.res_fc is not None: | |||
| resval = self.res_fc(h_dst).view(h_dst.shape[0], self._num_heads, self._out_feats) | |||
| # Use -1 rather than self._num_heads to handle broadcasting | |||
| resval = self.res_fc(h_dst).view(h_dst.shape[0], -1, self._out_feats) | |||
There was a problem hiding this comment.
Could you please explain why does it work?
There was a problem hiding this comment.
If we use self._num_heads, then we will get an error with view. If we use -1, it will be 1 in this case. We can add a tensor of shape (A, 1, C) to a tensor of shape (A, B, C).
BarclayII
approved these changes
Apr 27, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Previously the forward computation of
GATConvfails ifin_feats=out_featsandresidual=True.Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change