-
Notifications
You must be signed in to change notification settings - Fork 3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Dataloading] Make loader iters iterator #2886
Conversation
To trigger regression tests:
|
Hi @justusschock , I actually noticed the same issue and have a similar fix in #2878. Your fix seems simpler (I don't know PL very well) so let me give this a try. |
Worked like a charm. Thanks for your contribution! I'll incorporate your changes in my examples. |
Hi @BarclayII, thanks for reviewing and merging. I am not that familiar with dgl, but I know PL very good. If you need help creating the examples feel free to ping me (on GH or the PL slack) :) |
* pytorch lightning initial examples * revert most changes in dataloader to favor #2886. * address comments
Description
Makes all loader iters return
self
in__iter_
to enable type-checking withcollections.abc.Iterator
This allows checks in Libraries like PyTorch Lightning (Lightning-AI/pytorch-lightning#7164)
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes
__iter__
to all Iterators