Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix shape mismatch with block inputs for multiple modules #2962

Merged
merged 2 commits into from
Jun 1, 2021

Conversation

BarclayII
Copy link
Collaborator

Description

This is a reopen of #2947 (originally from @jxgu1016).

The test case was spelled wrong, and as a result some of cases are never tested.

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 31, 2021

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@BarclayII BarclayII linked an issue May 31, 2021 that may be closed by this pull request
@BarclayII BarclayII requested a review from VoVAllen May 31, 2021 10:22
Copy link
Collaborator

@VoVAllen VoVAllen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@BarclayII BarclayII merged commit fcfe52a into dmlc:master Jun 1, 2021
@BarclayII BarclayII deleted the fix-residual branch June 1, 2021 05:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

gatconv residual add miss match dim when using block
3 participants