Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Model] reformat and update performance of grace #3009

Merged
merged 4 commits into from
Jun 15, 2021
Merged

[Model] reformat and update performance of grace #3009

merged 4 commits into from
Jun 15, 2021

Conversation

hengruizhang98
Copy link
Contributor

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
    @mufeili

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 11, 2021

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@hengruizhang98
Copy link
Contributor Author

@dgl-bot run g4dn.4xlarge all dmlc/master

mufeili
mufeili approved these changes Jun 15, 2021
View reviewed changes
Copy link
Member

@mufeili mufeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mufeili mufeili merged commit b4ad59d into dmlc:master Jun 15, 2021
@hengruizhang98 hengruizhang98 deleted the grace branch June 15, 2021 10:06
@hengruizhang98 hengruizhang98 restored the grace branch June 15, 2021 10:07
@hengruizhang98 hengruizhang98 deleted the grace branch June 15, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufeili mufeili mufeili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hengruizhang98 @dgl-bot @mufeili