[Feature][GPU] Add function for setting weights of a sparse embedding on multiple GPUs. #3047
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
Rhett-Ying
pushed a commit
to Rhett-Ying/dgl
that referenced
this pull request
Jun 25, 2021
… on multiple GPUs. (dmlc#3047) * add unit test * Extend NDArrayPartition object * Add method for setting embedding, and improve documentation * Sync before returning * Use name unique to sparse embedding class to avoid delete Co-authored-by: xiang song(charlie.song) <classicxsong@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This renames the method
NodeEmbedding.gather_embedding()toNodeEmbedding.all_get_embedding()to make its usage more clear, and adds the methodNodeEmbedding.all_set_embedding(), which is needed by tests in #3034, for initializing the embedding to the same values as a pytorch embedding.Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change