Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug fix] Fix batch information with remove_nodes/edges applied #3119

Merged
merged 24 commits into from
Jul 13, 2021
Merged

[Bug fix] Fix batch information with remove_nodes/edges applied #3119

merged 24 commits into from
Jul 13, 2021

Conversation

mufeili
Copy link
Member

@mufeili mufeili commented Jul 7, 2021

Description

This PR updates batch information in remove_nodes and remove_edges as reported in #2310 .

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 7, 2021

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mufeili mufeili changed the title [Bug fix] Fix batch information with graph transformation applied [Bug fix] Fix batch information with remove_nodes/edges applied Jul 8, 2021
@mufeili mufeili requested a review from jermainewang July 8, 2021 05:24
Copy link
Collaborator

@BarclayII BarclayII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Could you update the docstrings for both functions? Looks like it is no longer discarding the batch information. And preferably the examples.

@jermainewang jermainewang added this to the v0.7 milestone Jul 12, 2021
@mufeili
Copy link
Member Author

mufeili commented Jul 13, 2021

Awesome! Could you update the docstrings for both functions? Looks like it is no longer discarding the batch information. And preferably the examples.

Thanks for the doc update!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants