Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Jenkins on Windows builds #324

Merged
merged 12 commits into from
Dec 22, 2018
Merged

[CI] Jenkins on Windows builds #324

merged 12 commits into from
Dec 22, 2018

Conversation

BarclayII
Copy link
Collaborator

@BarclayII BarclayII commented Dec 21, 2018

Description

Added Windows build & unit/example tests on PyTorch/CPU. The backend is built with MSBuild and MinGW is no longer required.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change

@VoVAllen
Copy link
Collaborator

Is jenkins workspace on windows reused by different commit? Since it's not docker, do we need to clean the directory or other environment we've used at the end of the process?
Also it's better to indicate which pytorch version is used in windows build.

@BarclayII
Copy link
Collaborator Author

Jenkins will have a dedicated workspace for each branch/PR so I think reusing the workspace should be fine. As long as we are cleaning up the build directory (which we do) then we should be safe.

@VoVAllen
Copy link
Collaborator

Thanks! Looks good to me.

Jenkinsfile Outdated Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Jenkinsfile Show resolved Hide resolved
Copy link
Member

@jermainewang jermainewang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jermainewang jermainewang merged commit 75e2af7 into master Dec 22, 2018
@jermainewang jermainewang deleted the jenkins-win branch December 22, 2018 05:39
@jermainewang jermainewang mentioned this pull request Feb 18, 2019
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants