[Tools] In tools/launch.py
, correctly pass all DGL client/server env vars if udf is a multi-command
#3245
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR modifies
tools/launch.py
so that a "multi command"udf_command
is properly supported.Specifically, this ensures that the DGL client/server env vars are:
(1) Persisted throughout all commands within the "multi command"
udf_command
(2) Don't pollute the environment after
udf_command
is completeDetails:
This does not break any backwards compatibility: existing single-cmd
udf_command
should still work exactly as before.Addresses Issue: #3160
Testing:
Unit tests pass:
Checklist
Please feel free to remove inapplicable items for your PR.
or have been fixed to be compatible with this change
Changes