Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tutorial] Batched Graph Classification #360

Merged
merged 10 commits into from
Jan 25, 2019
Merged

[Tutorial] Batched Graph Classification #360

merged 10 commits into from
Jan 25, 2019

Conversation

mufeili
Copy link
Member

@mufeili mufeili commented Jan 18, 2019

Description

Motivated by the forum discussion, we decide to add a tutorial on batched graph classification.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [Model], [Doc], [Feature]])
  • Changes are complete (i.e. I finished coding on this PR)
  • All changes have test coverage
  • Code is well-documented
  • To the my best knowledge, examples are either not affected by this change,
    or have been fixed to be compatible with this change
  • Related issue is referred in this PR

Changes

  • Added the tutorial as the last one in the basics section.
  • Modified docs/index.rst accordingly

@mufeili mufeili changed the title [Tutorial] batched_graph_classification [Tutorial] Batched Graph Classification Jan 19, 2019
Copy link
Collaborator

@BarclayII BarclayII left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Should we also mention that currently batched graphs does not work with torch.nn.DataParallel?

tutorials/basics/4_batch.py Outdated Show resolved Hide resolved
tutorials/basics/4_batch.py Outdated Show resolved Hide resolved
tutorials/basics/4_batch.py Outdated Show resolved Hide resolved
@jermainewang
Copy link
Member

@BarclayII better not. The support will be included in #356 .

@jermainewang
Copy link
Member

@mufeili updated the tutorial using the new dataset. The CI error should be resolved after #364 is merged.

@mufeili
Copy link
Member Author

mufeili commented Jan 25, 2019

@jermainewang

  • It now takes about within 30s to run the tutorial with some performance drop (argmax accuracy can still reach 80%). I added the note "Note that for deployment of the tutorial, we restrict our running time and you are likely to get a higher accuracy (80 % ~ 90%) than the ones printed below."
  • I also made some small fix to the doc for the dataset.

If this sounds good to you, just go ahead and merge it.

@jermainewang
Copy link
Member

Really great job @mufeili !

@jermainewang jermainewang merged commit 3cbfc25 into dmlc:master Jan 25, 2019
@jermainewang jermainewang mentioned this pull request Feb 18, 2019
26 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants