[Misc] Add MKL library path for standalone installation #5510
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
To trigger regression tests:
|
daniil-sizov
approved these changes
Mar 29, 2023
itaraban
force-pushed
the
fix_sparse_mkl_path
branch
from
ce56a7c
to
9a76f4a
Compare
frozenbugs
reviewed
Mar 30, 2023
dgl_sparse/CMakeLists.txt
Outdated
| @@ -50,5 +50,12 @@ target_include_directories(${LIB_DGL_SPARSE_NAME} PRIVATE "${CMAKE_SOURCE_DIR}/t | |||
| message(STATUS "DGL include directories: ${DGL_INCLUDE_DIRS}") | |||
| target_include_directories(${LIB_DGL_SPARSE_NAME} PRIVATE ${DGL_INCLUDE_DIRS}) | |||
| target_link_directories(${LIB_DGL_SPARSE_NAME} PRIVATE ${DGL_BUILD_DIR} "${DGL_BUILD_DIR}/third_party/dmlc-core") | |||
|
|
|||
| # Torch CMake sets up MKL library path only for conda distribution | |||
| # WA for standalone MKL installation | |||
There was a problem hiding this comment.
Workaround, I changed it to be more readable
dgl_sparse/CMakeLists.txt
Outdated
| @@ -50,5 +50,12 @@ target_include_directories(${LIB_DGL_SPARSE_NAME} PRIVATE "${CMAKE_SOURCE_DIR}/t | |||
| message(STATUS "DGL include directories: ${DGL_INCLUDE_DIRS}") | |||
| target_include_directories(${LIB_DGL_SPARSE_NAME} PRIVATE ${DGL_INCLUDE_DIRS}) | |||
| target_link_directories(${LIB_DGL_SPARSE_NAME} PRIVATE ${DGL_BUILD_DIR} "${DGL_BUILD_DIR}/third_party/dmlc-core") | |||
|
|
|||
| # Torch CMake sets up MKL library path only for conda distribution | |||
| # WA for standalone MKL installation | |||
There was a problem hiding this comment.
nit, end the sentence with dot.
itaraban
force-pushed
the
fix_sparse_mkl_path
branch
from
9a76f4a
to
0df796c
Compare
frozenbugs
reviewed
Mar 31, 2023
frozenbugs
approved these changes
Mar 31, 2023
|
FYI @czkkkkkk |
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
|
Why does this PR fix #5474 ? In the issue, you mentioned that "libxsmm can use different compiler from what was used in cmake". How does this PR fix the problem of libxsmm? |
czkkkkkk
approved these changes
Apr 3, 2023
czkkkkkk
pushed a commit
that referenced
this pull request
Apr 19, 2023
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
DominikaJedynak
pushed a commit
to DominikaJedynak/dgl
that referenced
this pull request
Mar 12, 2024
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix sparse library link issue, caused by wrong Torch MKL CMake settings
Resolves issue: #5474
Checklist
Please feel free to remove inapplicable items for your PR.
Changes