Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset] Actor #5511

Merged
merged 1 commit into from
Mar 31, 2023
Merged

[Dataset] Actor #5511

merged 1 commit into from
Mar 31, 2023

Conversation

mufeili
Copy link
Member

@mufeili mufeili commented Mar 30, 2023

Description

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mufeili mufeili mentioned this pull request Mar 30, 2023
6 tasks
@mufeili mufeili requested a review from frozenbugs March 30, 2023 09:40
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 30, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@jermainewang
Copy link
Member

BTW, after adding all these datasets, I wonder how about adding a wrapper that converts PyG's dataset into DGL?

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 30, 2023

Commit ID: 6788350

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mufeili
Copy link
Member Author

mufeili commented Mar 30, 2023

BTW, after adding all these datasets, I wonder how about adding a wrapper that converts PyG's dataset into DGL?

Sure

@jermainewang jermainewang merged commit 2b5921e into dmlc:master Mar 31, 2023
@mufeili mufeili mentioned this pull request Apr 18, 2023
8 tasks
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Co-authored-by: Ubuntu <ubuntu@ip-172-31-36-188.ap-northeast-1.compute.internal>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants