Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Performance Improvement] Make GPU sampling and to_block use pinned memory to decrease required synchronization #5685

Merged
merged 4 commits into from
May 17, 2023

Conversation

nv-dlasalle
Copy link
Collaborator

Description

This uses the pinned memory from #5366 to improve GPU->CPU communicating tensor sizes during sampling and to_block. This improves the performance of UVA and GPU sampling.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 13, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 13, 2023

Commit ID: 8caeb728fbd5e81fb1a11416b36e441d8da877ab

Build ID: 1

Status: ❌ CI test failed in Stage [Tensorflow GPU Unit test].

Report path: link

Full logs path: link

@nv-dlasalle nv-dlasalle changed the title Make GPU sampling and to_block use pinned memory to decrease required synchronization [Performance Improvement] Make GPU sampling and to_block use pinned memory to decrease required synchronization May 15, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented May 15, 2023

Commit ID: ce239062160d0e6d62c25c0af46b44f14d01ef95

Build ID: 2

Status: ❌ CI test failed in Stage [Tensorflow GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2023

Commit ID: 11e3b06ae18453f479f5223fd8b28e3dc24c3ae5

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented May 16, 2023

Commit ID: dcdefbc

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@nv-dlasalle nv-dlasalle merged commit 46af76c into dmlc:master May 17, 2023
Rhett-Ying pushed a commit that referenced this pull request Jun 20, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants