Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BugFix] Fix khop_adj #5754

Merged
merged 1 commit into from
Jun 7, 2023
Merged

[BugFix] Fix khop_adj #5754

merged 1 commit into from
Jun 7, 2023

Conversation

rudongyu
Copy link
Collaborator

@rudongyu rudongyu commented Jun 1, 2023

Description

Current khop_adj api wrongly includes a transpose operation when accessing adjacency matrix. Fix the bug.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 1, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@rudongyu rudongyu linked an issue Jun 1, 2023 that may be closed by this pull request
@rudongyu rudongyu requested review from czkkkkkk and mufeili June 1, 2023 01:38
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 1, 2023

Commit ID: 00ab57e

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@rudongyu rudongyu merged commit 9211d34 into dmlc:master Jun 7, 2023
caojy1998 pushed a commit to caojy1998/dgl that referenced this pull request Jun 13, 2023
Rhett-Ying pushed a commit that referenced this pull request Jun 20, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

request necesssary wranings
3 participants