Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Dataset] Add heterophilous graphs. #5853

Merged
merged 8 commits into from
Jun 15, 2023
Merged

[Dataset] Add heterophilous graphs. #5853

merged 8 commits into from
Jun 15, 2023

Conversation

OlegPlatonov
Copy link
Contributor

Description

Recently, several new heterophilous graph datasets have been proposed. This PR adds them to DGL. #5671

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 11, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 11, 2023

Commit ID: 41e3070

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mufeili mufeili self-requested a review June 12, 2023 02:35
@mufeili
Copy link
Member

mufeili commented Jun 12, 2023

Thank you for opening the PR! I'll take a look when I have time.

@mufeili
Copy link
Member

mufeili commented Jun 12, 2023 •
edited
Loading

Could you index them in the documentation by updating dgl.data.rst and adding corresponding unit tests? You may find it helpful to follow the practice of #5477 .

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 12, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 12, 2023

Commit ID: df19d0d73a9f3e2704be094d0b1dc95eae009e8f

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@OlegPlatonov
Copy link
Contributor Author

Could you index them in the documentation by updating dgl.data.rst and adding corresponding unit tests? You may find it helpful to follow the practice of #5477 .

Done. Let me know if anything else is needed.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

mufeili
mufeili reviewed Jun 13, 2023
View reviewed changes
Copy link
Member

@mufeili mufeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've made a pass and generally good except for some minor comments. Thanks for the great job!

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2023

Commit ID: 6a55cb4

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Jun 13, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2023

Commit ID: 6a55cb4

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 13, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Commit ID: e5a0492

Build ID: 6

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Jun 14, 2023

@dgl-bot

@mufeili
Copy link
Member

mufeili commented Jun 14, 2023

Lint check by lintrunner failed. Click "Details" to see the suggested fix.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Commit ID: e5a0492

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Commit ID: 19cde410fb407c3c7942f231c06b81e9b9c88182

Build ID: 8

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@OlegPlatonov
Copy link
Contributor Author

Lint check by lintrunner failed. Click "Details" to see the suggested fix.

Fixed

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Commit ID: d7d3bd0

Build ID: 9

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@mufeili
Copy link
Member

mufeili commented Jun 14, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 14, 2023

Commit ID: d7d3bd0

Build ID: 10

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mufeili mufeili merged commit 921476c into dmlc:master Jun 15, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
@OlegPlatonov @mufeili @DominikaJedynak
[Dataset] Add heterophilous graphs. (dmlc#5853)
ad39e34 
Co-authored-by: Mufei Li <mufeili1996@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mufeili mufeili mufeili approved these changes

Assignees
No one assigned
Labels
None yet
Projects
DGL Project Tracker
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@OlegPlatonov @dgl-bot @mufeili