Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Optimization] Use scipy's eigs instead of numpy in lap_pe #5855

Merged
merged 8 commits into from
Aug 24, 2023

Conversation

BarclayII
Copy link
Collaborator

Fixes #5854.

@BarclayII BarclayII requested a review from rudongyu June 12, 2023 02:44
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 12, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@BarclayII BarclayII closed this Jun 12, 2023
@BarclayII BarclayII reopened this Jun 29, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2023

Commit ID: 556675034f464aab0da05edc203fdc41b46dbafe

Build ID: 2

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2023

Commit ID: 7330fb967053e61c3e2a9aeb8631f278145defcd

Build ID: 3

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 4, 2023

Commit ID: 3f3b337a93c5691879b0a3e8876df690cf5b3e4b

Build ID: 4

Status: ❌ CI test failed in Stage [Tensorflow GPU Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 5, 2023

Commit ID: 4a4112a735504f98ff38aab5adfe2ac270d2bd01

Build ID: 5

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

Copy link
Collaborator

@rudongyu rudongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice work! I'm fine with the other parts. Could you add an example in test_module_lap_pe to cover the case of k+1<n-1 ?

python/dgl/transforms/functional.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 27, 2023

Commit ID: b2e1ce18a8df1d94e47fd36ad7ad92353b208a8c

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 3, 2023

Commit ID: 71d9c736015d281d4bbf1bdddcd8e2632366e65b

Build ID: 7

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

BarclayII and others added 2 commits August 21, 2023 12:44
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
@dgl-bot
Copy link
Collaborator

dgl-bot commented Aug 21, 2023

Commit ID: 214494dddab733c60cb4d8ef1cbd61fa5872edae

Build ID: 8

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@BarclayII BarclayII merged commit 019a1a6 into master Aug 24, 2023
2 checks passed
@BarclayII BarclayII deleted the fix-lap-pe-adj branch August 24, 2023 02:35
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
Co-authored-by: rudongyu <ru_dongyu@outlook.com>
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Co-authored-by: rudongyu <ru_dongyu@outlook.com>
Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dgl.lap_pe cannot scale to large graphs due to materialization of dense adjacency matrix
5 participants