Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Performance][CUDA] Labor UVA optimization #5885

Merged
merged 14 commits into from
Jul 13, 2023
Merged

[Performance][CUDA] Labor UVA optimization #5885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
88493c0
optimize indptr access
mfbalin Jun 17, 2023
2570f93
optimize indices access
mfbalin Jun 18, 2023
ffecadf
adding some tests for dgl.sampling.labors
mfbalin Jun 18, 2023
21f505e
fix linting
mfbalin Jun 18, 2023
650c72c
remove unnecessary parameter
mfbalin Jun 18, 2023
2f7ee29
add labor dataloader test as well
mfbalin Jun 19, 2023
d5da5e6
make sorted indices reads
mfbalin Jun 20, 2023
82590a0
use ndarray empty to create an array
mfbalin Jun 21, 2023
d5bbfae
Merge branch 'master' into labor_uvm_optimization
yaox12 Jun 28, 2023
6b52dba
address reviews
mfbalin Jun 29, 2023
c3deb84
minor fix for log_size function
mfbalin Jun 29, 2023
009be59
add short descriptions to tests.
mfbalin Jun 29, 2023
22b5d74
Merge branch 'master' into labor_uvm_optimization
Rhett-Ying Jul 3, 2023
3bead55
Merge branch 'master' into labor_uvm_optimization
mfbalin Jul 13, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions src/array/cpu/labor_pick.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,7 +31,6 @@
#include <algorithm>
#include <cmath>
#include <functional>
#include <iostream>
#include <memory>
#include <numeric>
#include <string>
Expand Down Expand Up @@ -124,7 +123,10 @@ auto compute_importance_sampling_probabilities(
var_1 = 0;
if (weighted) {
for (auto j = indptr[rid]; j < indptr[rid + 1]; j++)
var_1 += A[j] * A[j] / std::min(ONE, c * ps[j - indptr[rid]]);
// The check for zero is necessary for numerical stability
var_1 += A[j] > 0
frozenbugs marked this conversation as resolved.
Show resolved Hide resolved
? A[j] * A[j] / std::min(ONE, c * ps[j - indptr[rid]])
: 0;
} else {
for (auto j = indptr[rid]; j < indptr[rid + 1]; j++)
var_1 += ONE / std::min(ONE, c * ps[j - indptr[rid]]);
Expand Down Expand Up @@ -208,8 +210,9 @@ std::pair<COOMatrix, FloatArray> CSRLaborPick(
IdArray picked_row = NDArray::Empty({hop_size}, vidtype, ctx);
IdArray picked_col = NDArray::Empty({hop_size}, vidtype, ctx);
IdArray picked_idx = NDArray::Empty({hop_size}, vidtype, ctx);
FloatArray picked_imp =
NDArray::Empty({importance_sampling ? hop_size : 0}, dtype, ctx);
FloatArray picked_imp = importance_sampling
? NDArray::Empty({hop_size}, dtype, ctx)
: NullArray();
IdxType* picked_rdata = picked_row.Ptr<IdxType>();
IdxType* picked_cdata = picked_col.Ptr<IdxType>();
IdxType* picked_idata = picked_idx.Ptr<IdxType>();
Expand Down
Loading