Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NN] Refactor SpatialEncoder3d #5894

Merged
merged 9 commits into from
Jun 29, 2023
Merged

[NN] Refactor SpatialEncoder3d #5894

merged 9 commits into from
Jun 29, 2023

Conversation

rudongyu
Copy link
Collaborator

Description

Close the gap between SpatialEncoder3d implemented in DGL and original implementation for smooth weights remapping.

  • change the graph format input to tensor format input. (the conversion will be handled by a special collator)
  • update the offset of weights for scaling factors

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 21, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 21, 2023

Commit ID: a93c0d6

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 21, 2023

Commit ID: 66fa247

Build ID: 2

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 21, 2023

Commit ID: 9388150

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@rudongyu rudongyu requested a review from mufeili June 21, 2023 10:00
Copy link
Member

@mufeili mufeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done a pass

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2023

Commit ID: 2b76e04ea9fa4e29a4c75d1c832ae7cbfc6de8b0

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2023

Commit ID: 6575fb8622b768b8ea5d078de6b021d77a34a32d

Build ID: 5

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2023

Commit ID: 8b30a96

Build ID: 6

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

Copy link
Member

@mufeili mufeili left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm good. Thanks for the great efforts!

@mufeili
Copy link
Member

mufeili commented Jun 28, 2023

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2023

Commit ID: 8b30a96

Build ID: 7

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 28, 2023

Commit ID: 7778df5e718401c584f393ac38422b15a1951238

Build ID: 8

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jun 29, 2023

Commit ID: b7a9ed540a260dc54a794dd9ce2de222e2a00e9c

Build ID: 9

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@rudongyu rudongyu merged commit b51fb6f into dmlc:master Jun 29, 2023
1 check passed
keli-wen pushed a commit to keli-wen/dgl that referenced this pull request Jun 29, 2023
Rhett-Ying pushed a commit that referenced this pull request Aug 10, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants