Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bugfix] Allow pinning of empty tensor #6044

Merged
merged 3 commits into from
Jul 25, 2023

Conversation

nv-dlasalle
Copy link
Collaborator

Description

Calling pin_memory_() on a DGLBlock can generate errors for cases in which there are empty views. This PR makes it so we only ensure non-empty Tensors are contiguous and not views, since it is no-op in these cases.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 25, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Jul 25, 2023

Commit ID: 78559d0

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@nv-dlasalle nv-dlasalle merged commit c08192c into dmlc:master Jul 25, 2023
1 check passed
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants