[Build] Add CMake changes from conda-forge build #6189

hmacdope · 2023-08-22T03:12:26Z

Description

Related to #5718

Checklist

Please feel free to remove inapplicable items for your PR.

The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
All changes have test coverage
Code is well-documented
To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
Related issue is referred in this PR

Changes

Re-works CMake to allow building from external dependencies if required.
changes libxsmm to header only mode, seeking feedback on this part, we can add some more conditional complexity here if preferred.

dgl-bot · 2023-08-22T03:12:52Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-22T03:13:00Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-22T03:13:05Z

Commit ID: 48b4ce6

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-08-22T03:13:12Z

Commit ID: 48b4ce6

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

hmacdope · 2023-08-22T03:14:17Z

@jermainewang @frozenbugs, this is the PR to upstream the conda-forge cmake changes, let me know what you think and I will incorporate as soon as I can.

hmacdope · 2023-08-22T03:14:36Z

Also tagging @mikemhenry

frozenbugs · 2023-08-22T03:29:38Z

@dgl-bot

dgl-bot · 2023-08-22T03:46:06Z

Commit ID: 48b4ce6

Build ID: 3

Status: ❌ CI test failed in Stage [CPU Build].

Report path: link

Full logs path: link

hmacdope · 2023-08-22T04:18:30Z

libdgl.so: undefined reference to `dgemv_'
libdgl.so: undefined reference to `dgemm_'
libdgl.so: undefined reference to `sgemm_'
libdgl.so: undefined reference to `sgemv_'

Seems to be the issue in 3/75 of the builds. Are these symbols provided by complied libxsmm perhaps? Something else?

We also observed this making the recipie, resolved by making MKL a dependency for the recipe.

dgl-bot · 2023-08-22T04:19:05Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-22T04:19:17Z

Commit ID: 6caf5f1

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-08-22T07:47:43Z

@dgl-bot

dgl-bot · 2023-08-22T07:47:59Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-22T07:48:11Z

Commit ID: 2fbcbd4

Build ID: 5

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

dgl-bot · 2023-08-22T08:04:34Z

Commit ID: 2fbcbd4

Build ID: 6

Status: ❌ CI test failed in Stage [CPU Build].

Report path: link

Full logs path: link

hmacdope · 2023-08-22T14:03:32Z

Possibly related to using / not using -D_BLAS=0 https://libxsmm.readthedocs.io/en/latest/#link-instructions

frozenbugs · 2023-08-31T07:07:36Z

Hi @hmacdope, are you still working on resolving this issue? Let us know if you need any help from us. Thanks!

hmacdope · 2023-08-31T09:43:39Z

@frozenbugs Yes please, I can't figure out exactly why some builds are missing the symbols. Any ideas?

dgl-bot · 2023-08-31T09:43:44Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-31T09:43:55Z

Commit ID: eabb0ed

Build ID: 7

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

anko-intel · 2023-08-31T12:55:30Z

Possibly related to using / not using -D_BLAS=0 https://libxsmm.readthedocs.io/en/latest/#link-instructions

You are right, according to https://github.com/libxsmm/libxsmm#header-only you have to define __BLAS=0
so, adding it to lines 217-221:

if(USE_LIBXSMM)
  set(CMAKE_C_FLAGS "${CMAKE_C_FLAGS} -DUSE_LIBXSMM -DDGL_CPU_LLC_SIZE=40000000 -D__BLAS=0")
  set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -DUSE_LIBXSMM -DDGL_CPU_LLC_SIZE=40000000 -D__BLAS=0")
  message(STATUS "Build with LIBXSMM optimization.")
endif(USE_LIBXSMM)

seems to be enough

mikemhenry · 2023-08-31T20:42:32Z

@hmacdope can you make that change when you get a chance? I don't have write permission on your fork

dgl-bot · 2023-08-31T23:27:12Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-08-31T23:27:24Z

Commit ID: cfe3be4

Build ID: 8

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

hmacdope · 2023-08-31T23:27:50Z

@mikemhenry done.

@frozenbugs should be good to re-trigger CI :)

hmacdope · 2023-08-31T23:30:03Z

Thanks so much for the fix @anko-intel, much appreciated. :)

frozenbugs · 2023-09-01T02:27:23Z

@dgl-bot

dgl-bot · 2023-09-01T02:27:48Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-09-01T02:28:00Z

Commit ID: d3797c0

Build ID: 10

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

frozenbugs · 2023-09-01T02:28:43Z

@dgl-bot

dgl-bot · 2023-09-01T02:29:22Z

Commit ID: d3797c0

Build ID: 9

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

dgl-bot · 2023-09-01T03:04:46Z

Commit ID: d3797c0

Build ID: 11

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

CMakeLists.txt

dgl-bot · 2023-09-01T03:20:00Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-09-01T03:20:11Z

Commit ID: 2cf0766

Build ID: 12

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

cmake/modules/FindMETIS.cmake

dgl-bot · 2023-09-01T03:20:37Z

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

@dgl-bot

dgl-bot · 2023-09-01T03:20:48Z

Commit ID: 040e50e

Build ID: 13

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

mikemhenry · 2023-09-01T20:18:18Z

🎉 Awesome! I am really excited for the next dgl release

hmacdope · 2023-09-02T07:35:36Z

Thanks everyone!

Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>

hmacdope added 2 commits August 22, 2023 13:02

add cmake changes from conda-forge build

4aa180f

Merge branch 'master' into conda-forge-cmake-upstream

48b4ce6

hmacdope mentioned this pull request Aug 22, 2023

Up-streaming CMake changes tracker conda-forge/dgl-feedstock#15

Closed

frozenbugs self-requested a review August 22, 2023 03:29

Merge branch 'master' into conda-forge-cmake-upstream

6caf5f1

Merge branch 'master' into conda-forge-cmake-upstream

2fbcbd4

Merge branch 'master' into conda-forge-cmake-upstream

eabb0ed

add fix from @anko-intel

cfe3be4

Merge branch 'master' into conda-forge-cmake-upstream

d3797c0

frozenbugs approved these changes Sep 1, 2023

View reviewed changes

CMakeLists.txt Outdated Show resolved Hide resolved

CMakeLists.txt Show resolved Hide resolved

frozenbugs added 2 commits September 1, 2023 11:19

Update CMakeLists.txt

d7fa998

Update CMakeLists.txt

2cf0766

frozenbugs reviewed Sep 1, 2023

View reviewed changes

cmake/modules/FindMETIS.cmake Outdated Show resolved Hide resolved

Update cmake/modules/FindMETIS.cmake

040e50e

frozenbugs merged commit 4a42027 into dmlc:master Sep 1, 2023
1 of 2 checks passed

hmacdope deleted the conda-forge-cmake-upstream branch September 2, 2023 07:35

peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023

[Build] Add CMake changes from conda-forge build (dmlc#6189)

7a46591

Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>

DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024

[Build] Add CMake changes from conda-forge build (dmlc#6189)

ef7310e

Co-authored-by: Hongzhi (Steve), Chen <chenhongzhi.nkcs@gmail.com>

This pull request was closed.

[Build] Add CMake changes from conda-forge build #6189

[Build] Add CMake changes from conda-forge build #6189

Conversation

hmacdope commented Aug 22, 2023

Description

Checklist

Changes

dgl-bot commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

hmacdope commented Aug 22, 2023

hmacdope commented Aug 22, 2023

frozenbugs commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

hmacdope commented Aug 22, 2023 • edited Loading

dgl-bot commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

frozenbugs commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

dgl-bot commented Aug 22, 2023

hmacdope commented Aug 22, 2023

frozenbugs commented Aug 31, 2023

hmacdope commented Aug 31, 2023 • edited Loading

dgl-bot commented Aug 31, 2023

dgl-bot commented Aug 31, 2023

anko-intel commented Aug 31, 2023

mikemhenry commented Aug 31, 2023

dgl-bot commented Aug 31, 2023

dgl-bot commented Aug 31, 2023

hmacdope commented Aug 31, 2023

hmacdope commented Aug 31, 2023

frozenbugs commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

frozenbugs commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

dgl-bot commented Sep 1, 2023

mikemhenry commented Sep 1, 2023

hmacdope commented Sep 2, 2023

hmacdope commented Aug 22, 2023 •

edited

Loading

hmacdope commented Aug 31, 2023 •

edited

Loading