Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Dataset] Add peptides functional dataset in LRGB #6363

Merged
merged 2 commits into from
Sep 26, 2023

Conversation

paoxiaode
Copy link
Collaborator

Description

The peptides functional dataset based on DGLDataset
Related issue: #5352

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 21, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 21, 2023

Commit ID: 79bc259bcac4005f03fee9c7f05e02372cd9920e

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@paoxiaode paoxiaode changed the title [Dataset] Add peptides functional dataset [Dataset] Add peptides functional dataset in LRGB Sep 21, 2023
@frozenbugs
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 21, 2023

Commit ID: b7576cf951f47da9a04ca6b8cb8eedbce43db61f

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

frozenbugs commented Sep 21, 2023

@rudongyu please take another round of review.

Copy link
Collaborator

@rudongyu rudongyu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM except for a minor naming issue. Good Work!

python/dgl/data/lrgb.py Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Commit ID: 61f4dff

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Sep 26, 2023

Commit ID: 30d20c6

Build ID: 4

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit 614401f into dmlc:master Sep 26, 2023
1 of 2 checks passed
@paoxiaode paoxiaode deleted the LRGB branch September 26, 2023 12:54
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants