Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Sparse]Fix device check #6409

Merged
merged 5 commits into from
Oct 11, 2023
Merged

[Sparse]Fix device check #6409

merged 5 commits into from
Oct 11, 2023

Conversation

xiangyuzhi
Copy link
Collaborator

@xiangyuzhi xiangyuzhi commented Oct 9, 2023

Description

Add the device check for sparse operator. When user call the function and the device of input matrix is not the same as input tensor, raise an error.

Resolve #6393.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 9, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 9, 2023

Commit ID: 6ca3c4ae46403c8d818e3e02dab8c1e5fe7b3e74

Build ID: 1

Status: ❌ CI test failed in Stage [Lint Check].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 9, 2023

Commit ID: abc610aead663f0b3918fb4f2150fe9776dcc543

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi changed the title [Sparse][draft] Add device check [Sparse][Resolve #6393][draft] Add device check Oct 9, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 9, 2023

Commit ID: cef4335bd1a49ce680a2fb4b95e4979ddc18e6e5

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi changed the title [Sparse][Resolve #6393][draft] Add device check [Sparse][Resolve #6393][draft] Fix device check Oct 10, 2023
@xiangyuzhi xiangyuzhi changed the title [Sparse][Resolve #6393][draft] Fix device check [Sparse][Resolve #6393] Fix device check Oct 10, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 10, 2023

Commit ID: 4af25392649e2eb444a3cb29f5cc16ebc3798a0e

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@czkkkkkk czkkkkkk changed the title [Sparse][Resolve #6393] Fix device check [Sparse]Fix device check Oct 10, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Oct 10, 2023

Commit ID: cae86a85386899fd2e5421c1aa03ed6edfc3006a

Build ID: 5

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@xiangyuzhi xiangyuzhi merged commit 2ebfa6e into dmlc:master Oct 11, 2023
2 checks passed
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
Co-authored-by: Ubuntu <ubuntu@ip-172-31-24-117.ap-northeast-1.compute.internal>
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Co-authored-by: Ubuntu <ubuntu@ip-172-31-24-117.ap-northeast-1.compute.internal>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]DGL sparse run error message is incomplete
3 participants