Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update doc network_emb.py #6559

Merged
merged 1 commit into from
Nov 16, 2023
Merged

Update doc network_emb.py #6559

merged 1 commit into from
Nov 16, 2023

Conversation

AndreaPrati98
Copy link
Contributor

Description

The default value descrbed in the documentation of the DeepWalk code was wrong. Indeed, the default value for the negative_size parameter is 5 and not 1.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • [x ] The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

The default value descrbed in the documentation of the DeepWalk code was wrong. Indeed, the default value for the negative_size parameter is 5 and not 1.
@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 13, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 13, 2023

Commit ID: d9c6d2f

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@AndreaPrati98
Copy link
Contributor Author

it's just one line, it doesn't affect the code........ :(

Copy link
Collaborator

@frozenbugs frozenbugs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the catching!

@frozenbugs frozenbugs merged commit c76a43c into dmlc:master Nov 16, 2023
1 of 2 checks passed
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants