Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Fix issue about integer overflow #6586

Merged
merged 3 commits into from
Nov 22, 2023
Merged

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Nov 20, 2023

Fixes #6585.

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 20, 2023

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@mfbalin mfbalin changed the title Fix issue about 64-bit array length [CUDA] Fix issue about 64-bit array length Nov 20, 2023
@mfbalin mfbalin changed the title [CUDA] Fix issue about 64-bit array length [CUDA] Fix issue about integer overflow Nov 20, 2023
@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 20, 2023

Commit ID: 7e276c3

Build ID: 1

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin
Copy link
Collaborator Author

mfbalin commented Nov 21, 2023

@Rhett-Ying could you review this quick fix?

Copy link
Collaborator

@Rhett-Ying Rhett-Ying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

could you add a testcase for this issue?

@Rhett-Ying
Copy link
Collaborator

could you add a testcase for this issue?

It's probably not easy to add testcase for this issue in python code path as it needs to create a large graph.

@mfbalin
Copy link
Collaborator Author

mfbalin commented Nov 21, 2023

could you add a testcase for this issue?

It's probably not easy to add testcase for this issue in python code path as it needs to create a large graph.

I agree. It may take too much memory and runtime.

src/array/cuda/utils.h Outdated Show resolved Hide resolved
@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 22, 2023

Commit ID: c9a7510d4c86c9a7292b9e161ebd149ee356304a

Build ID: 2

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 22, 2023

Commit ID: c081f904c45115bf5415ac161376655e657da1f5

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit bfde142 into dmlc:master Nov 22, 2023
2 checks passed
@Rhett-Ying
Copy link
Collaborator

@mfbalin could you help resolve below warning which is the side effect of this PR?

utils.h:49:73: warning: comparison of integer expressions of different signedness: ‘long long unsigned int’ and ‘const long int’ [-Wsign-compare]
   49 |   while (bits < static_cast<int>(sizeof(T) * 8) && (1ull << bits) < range) {

peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

is there has max edge count limit?
3 participants