Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improving the JKNET example. #6596

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Improving the JKNET example. #6596

merged 1 commit into from
Nov 22, 2023

Conversation

drivanov
Copy link
Contributor

Description

Elimination of the UserWarning:

/usr/local/lib/python3.10/dist-packages/torch/nn/modules/rnn.py:881: UserWarning: RNN module weights are not part of single contiguous chunk of memory. This means they need to be compacted at every call, possibly greatly increasing memory usage. To compact weights again call flatten_parameters(). (Triggered internally at /opt/pytorch/pytorch/aten/src/ATen/native/cudnn/RNN.cpp:982.)

by using flatten_parameters() call for lstm mode.

Checklist

Please feel free to remove inapplicable items for your PR.

  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 22, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Nov 22, 2023

Commit ID: 4bc47b75d12f7dc4220e60a25085a1d63d8eda45

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit 09a1a2f into dmlc:master Nov 22, 2023
1 of 2 checks passed
@drivanov drivanov deleted the jknet branch November 22, 2023 21:51
peizhou001 pushed a commit to peizhou001/dgl that referenced this pull request Nov 27, 2023
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants