Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix num_labels to num_classes in dataset files #6666

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

HernandoR
Copy link
Contributor

Description

update the examples and 3 datasets, from num_labels to num_classes

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

examples are updated to use data.num_classes instead of nums_labels

each dataset that explicitly defined num_labels has been checked or updated to include num_classes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 2, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 2, 2023

Commit ID: df81ddb

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 4, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 4, 2023

Commit ID: 8989798

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@HernandoR
Copy link
Contributor Author

@Rhett-Ying Would you mind get someone review this?

@Rhett-Ying
Copy link
Collaborator

@dgl-bot

Copy link
Collaborator

@Rhett-Ying Rhett-Ying left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you run all these changed examples(running pytorch examples is enough) to make sure the api change does not cause regression issue? These examples are not covered in our CI.

@HernandoR
Copy link
Contributor Author

working on it

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 4, 2023

Commit ID: 8989798

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@HernandoR
Copy link
Contributor Author

It's cleared.

working on it

@Rhett-Ying Rhett-Ying merged commit 15d05be into dmlc:master Dec 4, 2023
2 checks passed
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants