Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[examples] fix Graphormer as key in state_dict has changed #6806

Merged
merged 2 commits into from
Dec 27, 2023

Conversation

songqing
Copy link
Contributor

Description

It seems the pre-trained model in the example Graphormer has changed and a key name has changed to another one, so, the example will fail as the original key can't be found.

f1

Change the key to the right name to solve the problem.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 21, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 21, 2023

Commit ID: 9ab5843

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 21, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 21, 2023

Commit ID: 08bf92d

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 22, 2023

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 22, 2023

Commit ID: 3be763e

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@Rhett-Ying
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Dec 22, 2023

Commit ID: 3be763e

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@songqing
Copy link
Contributor Author

@Rhett-Ying Could you help to review the PR?

@Rhett-Ying
Copy link
Collaborator

@songqing Have you run this example and does it work as expected?

@songqing
Copy link
Contributor Author

@songqing Have you run this example and does it work as expected?

Yes, this is my test.
f1

@Rhett-Ying Rhett-Ying merged commit d6bf038 into dmlc:master Dec 27, 2023
2 checks passed
DominikaJedynak pushed a commit to DominikaJedynak/dgl that referenced this pull request Mar 12, 2024
Co-authored-by: Rhett Ying <85214957+Rhett-Ying@users.noreply.github.com>
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants