Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DistDGL] Fixing bug in test_dist_objects #7179

Merged
merged 3 commits into from
Mar 7, 2024
Merged

Conversation

drivanov
Copy link
Contributor

@drivanov drivanov commented Feb 29, 2024

Description

The test tests/dist/test_dist_objects.py::test_dist_objects fails with following error message:

  File "/opt/dgl/dgl-source/tests/dist/python/run_dist_objects.py", line 50, in run_server
    g = dgl.distributed.DistGraphServer(
TypeError: DistGraphServer.__init__() got an unexpected keyword argument 'keep_alive'

It happens because keep_alive parameter was eliminated by

commit 0d9b6bfd5a1ac04ec9727c14fc662b4942700b24
Author: Rhett Ying <85214957+Rhett-Ying@users.noreply.github.com>
Date:   Mon Jul 3 09:26:27 2023 +0800

    [TensorpipeDeprecation] remove long live server support from DistDGL (#5931)

Today the parameters of DistGraphServer.__init__() are

    def __init__(
        self,
        server_id,
        ip_config,
        num_servers,
        num_clients,
        part_config,
        disable_shared_mem=False,
        graph_format=("csc", "coo"),
        use_graphbolt=False,
    ):

Checklist

Please feel free to remove inapplicable items for your PR.

  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 29, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Feb 29, 2024

Commit ID: 63218a2

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 1, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 1, 2024

Commit ID: ca5cfbe

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 4, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 4, 2024

Commit ID: f258170

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@frozenbugs frozenbugs self-requested a review March 7, 2024 02:14
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 7, 2024

Commit ID: b28485c36e1186f9f0e0982d86b033d67ee25a7f

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit 996a936 into dmlc:master Mar 7, 2024
2 checks passed
@drivanov drivanov deleted the distrib branch March 7, 2024 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants