Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DistDGL] Fixing warning in test_new_kvstore. #7180

Merged
merged 3 commits into from
Mar 7, 2024

Conversation

drivanov
Copy link
Contributor

@drivanov drivanov commented Mar 1, 2024

Description

The following warning

../../../usr/local/lib/python3.10/dist-packages/dgl/heterograph.py:92
  /usr/local/lib/python3.10/dist-packages/dgl/heterograph.py:92: DGLWarning: Recommend creating graphs by `dgl.graph(data)` instead of `dgl.DGLGraph(data)`.
    dgl_warning(

has been fixed. Minor cleanup was done by removing unused import statements.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 1, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 1, 2024

Commit ID: 9eb1d51f940493dfa91c849dcfb505ae61ae77eb

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 1, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 1, 2024

Commit ID: 68452ad

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 4, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 4, 2024

Commit ID: 12c909e

Build ID: 3

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@frozenbugs
Copy link
Collaborator

@dgl-bot

@frozenbugs frozenbugs self-requested a review March 7, 2024 02:14
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 7, 2024

Commit ID: d86f00c0d65d3705d05612b092727d5b8f8121be

Build ID: 4

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@Rhett-Ying Rhett-Ying merged commit 3fd6a5d into dmlc:master Mar 7, 2024
2 checks passed
@drivanov drivanov deleted the kvstore branch March 7, 2024 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants