Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GraphBolt] Fixing warning in test_to_pyg_data. #7210

Merged
merged 2 commits into from
Mar 17, 2024

Conversation

drivanov
Copy link
Contributor

Description

The following warning

tests/python/pytorch/graphbolt/test_minibatch.py:944
  /opt/dgl/dgl-source/tests/python/pytorch/graphbolt/test_minibatch.py:944: PytestAssertRewriteWarning: assertion is always true, perhaps remove parentheses?
    assert (

is fixed in graphbolt/test_minibatch.py::test_to_pyg_data test.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change

Changes

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 12, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 12, 2024

Commit ID: 3585a81

Build ID: 1

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@drivanov drivanov changed the title [GraphBolt] Fixing warnings in test_to_pyg_data. [GraphBolt] Fixing warning in test_to_pyg_data. Mar 12, 2024
@mfbalin mfbalin requested a review from RamonZhou March 13, 2024 17:40
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 13, 2024

Not authorized to trigger CI. Please ask core developer to help trigger via issuing comment:

  • @dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 13, 2024

Commit ID: fd9bc68

Build ID: 2

Status: ❌ CI test failed in Stage [Authentication].

Report path: link

Full logs path: link

@RamonZhou
Copy link
Collaborator

@dgl-bot

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 14, 2024

Commit ID: fd9bc68

Build ID: 3

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@mfbalin mfbalin merged commit aed161e into dmlc:master Mar 17, 2024
2 checks passed
@drivanov drivanov deleted the to_pig_data branch March 18, 2024 00:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants