Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CUDA] Make sanity check optional for dgl.create_block. #7240

Merged
merged 4 commits into from
Mar 26, 2024

Conversation

mfbalin
Copy link
Collaborator

@mfbalin mfbalin commented Mar 24, 2024

Description

The hetero sampling case has too many GPU synchronizations, we need to hunt them down one by one if we want to get good performance.

I would appreciate any help in this direction as some of these are inside DGL itself, not GraphBolt.

Checklist

Please feel free to remove inapplicable items for your PR.

  • The PR title starts with [$CATEGORY] (such as [NN], [Model], [Doc], [Feature]])
  • I've leverage the tools to beautify the python and c++ code.
  • The PR is complete and small, read the Google eng practice (CL equals to PR) to understand more about small PR. In DGL, we consider PRs with less than 200 lines of core code change are small (example, test and documentation could be exempted).
  • All changes have test coverage
  • Code is well-documented
  • To the best of my knowledge, examples are either not affected by this change, or have been fixed to be compatible with this change
  • Related issue is referred in this PR
  • If the PR is for a new model/paper, I've updated the example index here.

Changes

@mfbalin mfbalin requested a review from frozenbugs March 24, 2024 16:56
@mfbalin mfbalin force-pushed the dgl_create_block_synch_eliminate branch from bb989f9 to 7bd258f Compare March 24, 2024 16:56
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

To trigger regression tests:

  • @dgl-bot run [instance-type] [which tests] [compare-with-branch];
    For example: @dgl-bot run g4dn.4xlarge all dmlc/master or @dgl-bot run c5.9xlarge kernel,api dmlc/master

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

Commit ID: bb989f9

Build ID: 1

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@mfbalin mfbalin requested a review from BarclayII March 24, 2024 16:58
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

Commit ID: 7bd258f

Build ID: 2

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@mfbalin mfbalin force-pushed the dgl_create_block_synch_eliminate branch from c4f323f to bf587d4 Compare March 24, 2024 20:57
@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

Commit ID: c4f323f

Build ID: 3

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

Commit ID: bf587d4

Build ID: 4

Status: ⚪️ CI test cancelled due to overrun.

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

Commit ID: 47e46c2

Build ID: 5

Status: ❌ CI test failed in Stage [Torch CPU (Win64) Unit test].

Report path: link

Full logs path: link

@dgl-bot
Copy link
Collaborator

dgl-bot commented Mar 24, 2024

Commit ID: 7a8f134

Build ID: 6

Status: ✅ CI test succeeded.

Report path: link

Full logs path: link

@frozenbugs frozenbugs merged commit 7815fe8 into dmlc:master Mar 26, 2024
2 checks passed
@mfbalin mfbalin deleted the dgl_create_block_synch_eliminate branch March 26, 2024 02:15
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants